launchpad-reviewers team mailing list archive

[Tim Penhey <tim.penhey@xxxxxxxxxxxxx>]

Tim Penhey has proposed merging lp:~thumper/launchpad/fix-mirror-failure-story into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #610301 xx-branch-mirror-failures.txt tries to mirror a hosted branch
  https://bugs.launchpad.net/bugs/610301


Simple fix for the mirror failure testing on hosted branches is to remove that hunk of the test.

Part of my pre-work for making startMirror, requestMirror and mirrorComplete blow up with hosted branches.
-- 
https://code.launchpad.net/~thumper/launchpad/fix-mirror-failure-story/+merge/31010
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~thumper/launchpad/fix-mirror-failure-story into lp:launchpad/devel.

=== modified file 'lib/lp/code/stories/branches/xx-branch-mirror-failures.txt'
--- lib/lp/code/stories/branches/xx-branch-mirror-failures.txt	2010-04-23 08:12:35 +0000
+++ lib/lp/code/stories/branches/xx-branch-mirror-failures.txt	2010-07-27 03:23:31 +0000
@@ -213,19 +213,3 @@
     None
     >>> print find_tag_by_id(browser.contents, 'mirror-of-ssh')
     None
-
-
-== Hosted branch mirror failure messages ==
-
-A hosted branch with an error message does show a mirror-failure.
-
-    >>> login(ANONYMOUS)
-    >>> hosted_branch = factory.makeAnyBranch()
-    >>> hosted_branch.mirrorFailed('Some weird internal failure.')
-    >>> branch_location = canonical_url(hosted_branch)
-    >>> logout()
-
-    >>> browser = setupBrowser()
-    >>> browser.open(branch_location)
-    >>> print_browser_tag(browser, 'mirror-failure')
-    Some weird internal failure.