launchpad-reviewers team mailing list archive

[Tim Penhey <tim.penhey@xxxxxxxxxxxxx>]

Tim Penhey has proposed merging lp:~thumper/launchpad/stop-factory-mirroring into lp:launchpad/devel with lp:~thumper/launchpad/fix-mirror-failure-story as a prerequisite.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #610302 LaunchpadObjectFacdtory should not requestMirror on every branch
  https://bugs.launchpad.net/bugs/610302


Part of my pre-work for making startMirror, requestMirror and mirrorComplete blow up with hosted branches.
-- 
https://code.launchpad.net/~thumper/launchpad/stop-factory-mirroring/+merge/31011
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~thumper/launchpad/stop-factory-mirroring into lp:launchpad/devel.

=== modified file 'lib/lp/testing/factory.py'
--- lib/lp/testing/factory.py	2010-07-26 06:21:45 +0000
+++ lib/lp/testing/factory.py	2010-07-27 03:27:49 +0000
@@ -1121,7 +1121,8 @@
             branch.createBranchRevision(sequence, revision)
             parent = revision
             parent_ids = [parent.revision_id]
-        branch.startMirroring()
+        if branch.branch_type not in (BranchType.REMOTE, BranchType.HOSTED):
+            branch.startMirroring()
         removeSecurityProxy(branch).branchChanged(
             '', parent.revision_id, None, None, None)
         branch.updateScannedDetails(parent, sequence)