launchpad-reviewers team mailing list archive

[Max Bowsher <maxb@xxxxxxx>]

Review: Needs Information
> launchpad-dependencies is also what gets deployed on the PQM, and PQM
> needs those dependencies installed so it can run the python-debian
> testsuite.

1) Why does PQM need to run the python-debian testsuite?

2) Why is it launchpad-dependencies' responsibility to ensure PQM has dependencies for non-Launchpad software?

3) If question 2 is disregarded on the grounds of it being a hideous hack but worthwhile for simplicity's sake, there must be a comment to explain to future developers that the dependency needs to stay, despite being redundant for Launchpad's purposes.
-- 
https://code.launchpad.net/~jelmer/meta-lp-deps/chardet-dep/+merge/31260
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/meta-lp-deps/chardet-dep into lp:meta-lp-deps.