launchpad-reviewers team mailing list archive

[Jelmer Vernooij <jelmer@xxxxxxxxx>]

Jelmer Vernooij has proposed merging lp:~jelmer/launchpad/fix-maintainer-comment into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers): code


Add a comment explaining some strange behaviour in fix_maintainer().
-- 
https://code.launchpad.net/~jelmer/launchpad/fix-maintainer-comment/+merge/32762
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/fix-maintainer-comment into lp:launchpad/devel.

=== modified file 'lib/lp/archiveuploader/utils.py'
--- lib/lp/archiveuploader/utils.py	2010-08-01 06:59:04 +0000
+++ lib/lp/archiveuploader/utils.py	2010-08-16 13:26:42 +0000
@@ -266,6 +266,10 @@
     # Force the name to be UTF-8
     name = force_to_utf8(name)
 
+    # If the maintainer's name contains a full stop then the whole field will
+    # not work directly as an email address due to a misfeature in the syntax
+    # specified in RFC822; see Debian policy 5.6.2 (Maintainer field syntax)
+    # for details.
     if name.find(',') != -1 or name.find('.') != -1:
         rfc822_maint = "%s (%s)" % (email, name)
         rfc2047_maint = "%s (%s)" % (email, rfc2047_name)