launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/member-icons-fix into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #614649 Title for "member of" icons unhelpful
  https://bugs.launchpad.net/bugs/614649


Summary

Fixes a really nasty hover over string caused by a missing semi-colon.

Proposed fix

Add the semi-colon.

Pre-implementation notes

Related to another branch, and found in QA.

Implementation details

Added a semi colon to make the alt a separate attribute rather than part of the title attribute.

Demo and Q/A

Hovering over the icons in the person overview should show Member of [team], only. Currently it shows Member of [team] alt Icon of ...

lint
= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/person-portlet-contact-details.pt
-- 
https://code.launchpad.net/~jcsackett/launchpad/member-icons-fix/+merge/32763
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/member-icons-fix into lp:launchpad/devel.

=== modified file 'lib/lp/registry/templates/person-portlet-contact-details.pt'
--- lib/lp/registry/templates/person-portlet-contact-details.pt	2010-08-11 13:23:32 +0000
+++ lib/lp/registry/templates/person-portlet-contact-details.pt	2010-08-16 13:27:44 +0000
@@ -83,7 +83,7 @@
       <a tal:repeat="team context/@@+restricted-membership/teams_with_icons"
          tal:attributes="href team/fmt:url"
         ><img tal:attributes="src team/icon/getURL;
-                              title string:Member of ${team/displayname}
+                              title string:Member of ${team/displayname};
                               alt string:Icon of ${team/displayname}"
       /></a>
     </div>