launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Curtis Hovey has proposed merging lp:~sinzui/launchpad/remove-mailman-beta-key into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #618655 remove mailman.beta_testers_team from config
  https://bugs.launchpad.net/bugs/618655


This is my branch to delete the mailman.beta_testers_team config key.

    lp:~sinzui/launchpad/remove-mailman-beta-key
    Diff size: 14
    Launchpad bug:
          https://bugs.launchpad.net/bugs/618655
    Test command: ./bin/test -vv -t mailing
    Pre-implementation: lifeless
    Target release: 10.09


Delete the mailman.beta_testers_team config key
-----------------------------------------------

Users are joining mailing-list-beta-testers, but mailing lists have been
in
general release for 2 years. No code uses the config key. The key needs
to be
removed, then the team can be deleted.


Rules
-----

All environments are inheriting the mailing-list-beta-testers key from
the
schema's default value. Removing the key will remove it from all
environments,
not that they will notice since no code knows about the key.

    * Delete the key from schema-lazr.conf


QA
--

    * Verify you can create a mailing list.


Lint
----

Linting changed files:
  lib/canonical/config/schema-lazr.conf


Test
----

No tests changed since nothing requires the key. I ran all the mailing
lists
tests and created a list on dev. I also deleted the
~mailing-list-beta-testers
team in staging a few days ago, nothing broke.


Implementation
--------------

    * lib/canonical/config/schema-lazr.conf
      Delete the lines that define the mailing-list-beta-testers key.
-- 
https://code.launchpad.net/~sinzui/launchpad/remove-mailman-beta-key/+merge/33042
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/remove-mailman-beta-key into lp:launchpad/devel.

=== modified file 'lib/canonical/config/schema-lazr.conf'
--- lib/canonical/config/schema-lazr.conf	2010-08-06 17:39:52 +0000
+++ lib/canonical/config/schema-lazr.conf	2010-08-18 18:51:02 +0000
@@ -1287,9 +1287,6 @@
 shared_secret: sutsGNcUEpc
 
 # datatype: string
-beta_testers_team: mailing-list-beta-testers
-
-# datatype: string
 list_help_header: https://help.launchpad.net/ListHelp
 
 # datatype: string