launchpad-reviewers team mailing list archive

[Bryce Harrington <bryce@xxxxxxxxxxxxxxxxxxx>]

Bryce Harrington has proposed merging lp:~bryceharrington/launchpad/lp-617102 into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #617102 Launchpad mischaracterizes openSUSE remote bug tracker status
  https://bugs.launchpad.net/bugs/617102


UPSTREAM/RESOLVED and UPSTREAM/CLOSED were being listed as "Fix Released", which is confusing in Launchpad because there isn't a "fix", and won't be one available from that tracker.  "Won't Fix" is a better indication of what's going on - the distro decided not to fix the issue and instead punted it upstream.



-- 
https://code.launchpad.net/~bryceharrington/launchpad/lp-617102/+merge/33061
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bryceharrington/launchpad/lp-617102 into lp:launchpad/devel.

=== modified file 'lib/lp/bugs/doc/externalbugtracker-bugzilla.txt'
--- lib/lp/bugs/doc/externalbugtracker-bugzilla.txt	2010-04-21 10:30:24 +0000
+++ lib/lp/bugs/doc/externalbugtracker-bugzilla.txt	2010-08-18 22:07:49 +0000
@@ -285,6 +285,8 @@
     'Fix Committed'
     >>> external_bugzilla.convertRemoteStatus('RESOLVED FIXED').title
     'Fix Released'
+    >>> external_bugzilla.convertRemoteStatus('RESOLVED UPSTREAM').title
+    "Won't Fix"
     >>> external_bugzilla.convertRemoteStatus(
     ...     'CLOSED PATCH_ALREADY_AVAILABLE').title
     'Fix Released'
@@ -295,7 +297,7 @@
     >>> external_bugzilla.convertRemoteStatus('CLOSED INVALID').title
     'Invalid'
     >>> external_bugzilla.convertRemoteStatus('CLOSED UPSTREAM').title
-    'Fix Released'
+    "Won't Fix"
 
 If the status can't be converted an UnknownRemoteStatusError will be
 returned.

=== modified file 'lib/lp/bugs/externalbugtracker/bugzilla.py'
--- lib/lp/bugs/externalbugtracker/bugzilla.py	2010-04-21 10:30:24 +0000
+++ lib/lp/bugs/externalbugtracker/bugzilla.py	2010-08-18 22:07:49 +0000
@@ -230,9 +230,9 @@
         ('RESOLVED', 'VERIFIED', 'CLOSED',
             LookupTree(
                 ('CODE_FIX', 'CURRENTRELEASE', 'ERRATA', 'NEXTRELEASE',
-                 'PATCH_ALREADY_AVAILABLE', 'FIXED', 'RAWHIDE', 'UPSTREAM',
+                 'PATCH_ALREADY_AVAILABLE', 'FIXED', 'RAWHIDE',
                  BugTaskStatus.FIXRELEASED),
-                ('WONTFIX', BugTaskStatus.WONTFIX),
+                ('WONTFIX', 'UPSTREAM', BugTaskStatus.WONTFIX),
                 (BugTaskStatus.INVALID,))),
         ('REOPENED', 'NEW', 'UPSTREAM', 'DEFERRED', BugTaskStatus.CONFIRMED),
         ('UNCONFIRMED', BugTaskStatus.NEW),