launchpad-reviewers team mailing list archive

[Abel Deuring <abel.deuring@xxxxxxxxxxxxx>]

Abel Deuring has proposed merging lp:~adeuring/launchpad/bug-581626 into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


This branch is a fix for bug 581626: "Project names aren't linked on Bugs front page".

test: ./bin/test -t xx-front-page-bug-lists.txt

no lint

-- 
https://code.launchpad.net/~adeuring/launchpad/bug-581626/+merge/35281
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~adeuring/launchpad/bug-581626 into lp:launchpad/devel.

=== modified file 'lib/lp/bugs/stories/bugs/xx-front-page-bug-lists.txt'
--- lib/lp/bugs/stories/bugs/xx-front-page-bug-lists.txt	2010-02-09 12:13:43 +0000
+++ lib/lp/bugs/stories/bugs/xx-front-page-bug-lists.txt	2010-09-13 13:27:52 +0000
@@ -41,28 +41,48 @@
     </span>
 
 The list of recently reported bugs contains up to the last 5 bugs reported
-across Launchpad.
+across Launchpad. The text for each bigs contains links to the bug itself,
+to the bug target and to the bug reporter's page.
 
     >>> for tr in reported_bugs('tr'):
     ...     icon_td, summary_td, = tr('td')
     ...     print "%s: %s" % (
-    ...         summary_td.b.renderContents().strip(),
+    ...         summary_td.b.a.renderContents().strip(),
     ...         summary_td.a.renderContents())
-    Bigfixer:
-             Summary for new bug ...
-    <BLANKLINE>
-    Bigfixer:
-             Summary for new bug ...
-    <BLANKLINE>
-    Bigfixer:
-             Summary for new bug ...
-    <BLANKLINE>
-    Bigfixer:
-             Summary for new bug ...
-    <BLANKLINE>
-    Bigfixer:
-             Summary for new bug ...
-    <BLANKLINE>
+    ...     bug_link, bug_target_link, bug_reporter_link = summary_td('a')
+    ...     print bug_link['href']
+    ...     print bug_target_link['href']
+    ...     print bug_reporter_link['href']
+    Bigfixer:
+             Summary for new bug ...
+    <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
+    Bigfixer:
+             Summary for new bug ...
+    <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
+    Bigfixer:
+             Summary for new bug ...
+    <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
+    Bigfixer:
+             Summary for new bug ...
+    <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
+    Bigfixer:
+             Summary for new bug ...
+    <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
 
 
 Fixed bugs
@@ -86,20 +106,39 @@
     >>> for tr in fixed_bugs('tr'):
     ...     icon_td, summary_td, = tr('td')
     ...     print "%s: %s" % (
-    ...         summary_td.b.renderContents().strip(),
+    ...         summary_td.b.a.renderContents().strip(),
     ...         summary_td.a.renderContents())
+    ...     bug_link, bug_target_link, bug_reporter_link = summary_td('a')
+    ...     print bug_link['href']
+    ...     print bug_target_link['href']
+    ...     print bug_reporter_link['href']
     Bigfixer:
              Summary for new bug 10
     <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
     Bigfixer:
              Summary for new bug 9
     <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
     Bigfixer:
              Summary for new bug 8
     <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
     Bigfixer:
              Summary for new bug 7
     <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...
     Bigfixer:
              Summary for new bug 6
     <BLANKLINE>
+    /bugs/...
+    /bigfixer
+    http://launchpad.dev/~person-name...

=== modified file 'lib/lp/bugs/templates/bug-listing-detailed.pt'
--- lib/lp/bugs/templates/bug-listing-detailed.pt	2010-01-12 14:13:26 +0000
+++ lib/lp/bugs/templates/bug-listing-detailed.pt	2010-09-13 13:27:52 +0000
@@ -10,9 +10,9 @@
       </a>
     </div>
     <div class="lesser">
-      in 
+      in
         <tal:per_pillar repeat="pillar context/affected_pillars">
-          <b tal:content="pillar/displayname" />,
+          <b tal:content="structure pillar/fmt:link:bugs" />,
         </tal:per_pillar>
       reported
       <span