launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~bac/launchpad/cherrypick-633926 into lp:~launchpad-pqm/launchpad/production-devel

To: Brad Crittenden <bac@xxxxxxxxxxxxx>
From: Jonathan Lange <jml@xxxxxxxxx>
Date: Mon, 13 Sep 2010 15:54:46 -0000
In-reply-to: <20100913134853.22860.90412.launchpad@loganberry.canonical.com>
Reply-to: mp+35286@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I'm OK with this change being cherry-picked.

Regarding the code, I'm surprised that you need to log in as an admin to call factory.makePerson. In any case, you can log in as an admin using 'login_celebrity("admin")' (or one of its variants, see lp.testing._login).


-- 
https://code.launchpad.net/~bac/launchpad/cherrypick-633926/+merge/35286
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/cherrypick-633926 into lp:~launchpad-pqm/launchpad/production-devel.

References

[Merge] lp:~bac/launchpad/cherrypick-633926 into lp:~launchpad-pqm/launchpad/production-devel
From: Brad Crittenden, 2010-09-13