launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

I just realized I should have posted this as a reply, not a separate comment.  In a nutshell: two to three times faster, gaining more with larger data sets; and 40% smaller output (though I didn't particularly aim for it, just something nicer to read) with less than half the number of lines.

I do agree that in principle we should use the TAL.  In this case however, with the variable columns list, it was a small step from (pre) moving into the view all cyclomatic complexity that shouldn't have been in the TAL in the first place, to (post) rendering entire rows there.
-- 
https://code.launchpad.net/~jtv/launchpad/templates-listing/+merge/35185
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/templates-listing into lp:launchpad/devel.