launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

> This is probably unrelated to your changes, but I thought I'd mention anyway: when looking at https://translations.launchpad.dev/kubuntu anonymously I see only the one sentence stating LP doesn't know about translations for it, but when I'm logged in as an admin I see all the edit links (which is expected) and the list of translations for the krunchy distro series (which I wasn't expecting given that it's not shown for anonymous users). 

This is consistent with behavior relating to the use of official_rosetta; on Products (which were the only page using the setting before), a person with Translation Admin privs could see all the settings stuff even when rosetta was off. I elected to maintain that here. for the other non-launchpad settings, and incorporate that across the board.

My understanding is b/c the process of turning rosetta on is somewhat cumbersome--this allows the admin to set everything up properly before stating that a project uses Launchpad for translations. 

All of that said, I think is related to the bug mentioned in the MP, which is all about much clearer configuration of translations (and will necessarily include the configuration involved in this branch), but which felt out of scope for this branch's purpose.

> This is probably not related either, but on https://translations.launchpad.dev/kubuntu/krunch, why am I allowed to change translations' permissions/settings even though LP is not used to translate kubuntu? I'd expect to be directed to /kubuntu to configure translations instead.

After speaking with Jeroen and Curtis, it was indicated that series, while having a configuration state related to their distro or product, are actually independent of them in some ways. Again, I think there may be some more work to land related to this--whether as part of this branch or in a separate one. I thought separate, but could be convinced otherwise.

-- 
https://code.launchpad.net/~jcsackett/launchpad/unknown-translations-service-643545-0/+merge/36464
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/unknown-translations-service-643545-0 into lp:launchpad/devel.