launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/remove-cache-private-650668 into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #650668 remove all cache:private calls from templates
  https://bugs.launchpad.net/bugs/650668


Summary
=======

Removes the two instances of cache:private in the registry app, as they're unneeded and cause errors.

Proposed Fix
============

Remove the two instances the cache:private directive is used in the registry templates.

Pre-Implementation Talk
=======================

Spoke with Curtis Hovey.

Implementation details
======================

As in proposed.

Tests
=====

bin/test -t TestMilestoneViews
bin/test -t test_person_views
bin/test -t TestProductSeriesViews

Demo and Q/A
============

Related software on a ~person page should still show normally; productseries and milestone views should all show up normally.

Lint
====

make lint output:

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/person-related-software.pt
  lib/lp/registry/templates/productseries-milestone-table-row.pt


-- 
https://code.launchpad.net/~jcsackett/launchpad/remove-cache-private-650668/+merge/37145
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/remove-cache-private-650668 into lp:launchpad/devel.

=== modified file 'lib/lp/registry/templates/person-related-software.pt'
--- lib/lp/registry/templates/person-related-software.pt	2010-07-09 22:56:40 +0000
+++ lib/lp/registry/templates/person-related-software.pt	2010-09-30 15:33:02 +0000
@@ -18,7 +18,6 @@
     <tal:navlinks replace="structure context/@@+related-software-navlinks"/>
   </div>
 
-  <tal:cache content="cache:private, 30 minute">
   <div id="packages">
 
   <tal:maintained-packages
@@ -151,7 +150,6 @@
       doesn't own or drive any projects.
     </p>
   </div>
-  </tal:cache>
 </div>
 
 <metal:macros fill-slot="bogus">

=== modified file 'lib/lp/registry/templates/productseries-milestone-table-row.pt'
--- lib/lp/registry/templates/productseries-milestone-table-row.pt	2010-08-27 15:44:38 +0000
+++ lib/lp/registry/templates/productseries-milestone-table-row.pt	2010-09-30 15:33:02 +0000
@@ -4,8 +4,7 @@
   xmlns:i18n="http://xml.zope.org/namespaces/i18n";
   define="milestone_menu view/milestone/menu:overview;
           milestone view/milestone;
-          release view/release"
-  tal:content="cache:private, 1 hour, milestone/id">
+          release view/release">
   <tr>
     <td>
       <img src="/@@/milestone" alt="" />