launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/windmill-1.3r1544 into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #652626 Windmill egg needs to be upgraded to fix test breakages
  https://bugs.launchpad.net/bugs/652626


See bug 652626

The version of windmill packaged with launchpad, currently 1.3r1440, has a bug which prevents some newly written windmill tests from running. The windmill bug results in code like the following:

client.asserts.assertProperty(id=u"field.review_type", validator='disabled|false')

failing with an array index error.

The windmill trunk has already been updated to fix this bug. A new windmill package has been built from the tip revision of the windmill trunk (r1544). The package is windmill-1.3r1544.tar.gz.

Implementation

  This branch updates the buildout config so the new windmill package is used.

Tests

  The tests from branch lp:~wallyworld/launchpad/reviews-without-reviewer which failed with the older version of 
  windmill were re-run and they now pass.

  bin/test -vvt TestRequestReview

  A selection of other windmill tests were also run - regression testing.

-- 
https://code.launchpad.net/~wallyworld/launchpad/windmill-1.3r1544/+merge/37209
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/windmill-1.3r1544 into lp:launchpad/devel.

=== modified file 'versions.cfg'
--- versions.cfg	2010-09-18 08:00:27 +0000
+++ versions.cfg	2010-10-01 02:38:54 +0000
@@ -76,10 +76,11 @@
 van.testing = 2.0.1
 wadllib = 1.1.5
 webunit = 1.3.8
-# r1440 of lp:~bjornt/windmill/1.3-lp. It includes our patches to make test
-# setup and tear down more robust, which didn't make it into the 1.3 release.
-# Windmill 1.5 will include our patches.
-windmill = 1.3beta3-lp-r1440
+# r1544 of lp:windmill (the tip revision at the time of packaging).
+# We need to use this revison rather than the official 1.3 release since 
+# there is a bug fix for WindmillTestClient.asserts.assertProperty() which 
+# makes this api call work property on html disabled and readonly attributes.
+windmill = 1.3r1544
 wsgi-fileserver = 0.2.7
 wsgi-intercept = 0.4
 wsgi-jsonrpc = 0.2.8