launchpad-reviewers team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Brian Murray has proposed merging lp:~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #347218 Allow bug supervisors to make tags official
  https://bugs.launchpad.net/bugs/347218


This is a follow up to https://code.edge.launchpad.net/~brian-murray/launchpad/modify-official-bug-tags-permissions/+merge/37758.  I missed moving the set_attribute for official_bug_tags from launchpad.Edit to launchpad.BugSupervisor for a distribution.  It works fine for products though.
-- 
https://code.launchpad.net/~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags/+merge/38743
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags into lp:launchpad/devel.

=== modified file 'lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt'
--- lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt	2010-10-15 14:26:57 +0000
+++ lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt	2010-10-18 18:04:46 +0000
@@ -71,6 +71,17 @@
     >>> print bug_super_browser.url
     http://bugs.launchpad.dev/youbuntu/+manage-official-tags
 
+The bug supervisor can also set the tags for the product.
+
+    >>> bug_super_browser.getControl('Official Bug Tags').value = 'foo bar'
+    >>> bug_super_browser.getControl('Save').click()
+    >>> print bug_super_browser.url
+    http://bugs.launchpad.dev/youbuntu
+    >>> bug_super_browser.open(
+    ...     'http://bugs.launchpad.dev/youbuntu/+manage-official-tags')
+    >>> print bug_super_browser.getControl('Official Bug Tags').value
+    bar foo
+
 == Official Tags on Bug Pages ==
 
 Official tags are displayed using a different style from unofficial ones.

=== modified file 'lib/lp/registry/configure.zcml'
--- lib/lp/registry/configure.zcml	2010-10-14 16:59:46 +0000
+++ lib/lp/registry/configure.zcml	2010-10-18 18:04:46 +0000
@@ -1475,7 +1475,6 @@
                 mugshot
                 official_answers
                 official_blueprints
-                official_bug_tags
                 official_malone
                 official_rosetta
                 owner
@@ -1483,6 +1482,10 @@
                 summary
                 title"/>
         <require
+            permission="launchpad.BugSupervisor"
+            set_attributes="
+                official_bug_tags"/>
+        <require
             permission="launchpad.TranslationsAdmin"
             set_attributes="
                 language_pack_admin