launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Review: Approve
> Thanks for the most excellent review. It's the most thorough one
> I've had.

I hope it was useful...

I often do quite thorough reviews and I worry that I'm being too
thorough. Let me know if you ever feel that my reviews are
demotivating or too picky. That would mean I'm doing it wrong :)


[14]

> I think Array.unique() is only available in YUI 3.2 and at the time
> of writing we were not using that version yet. I originally tried to
> use Array.unique() only to be disappointed :-(

Okay. Fwiw, this should work now in Launchpad, though it's confusing
because Array.unique() is a static function (or whatever YUI calls
it), and is not available on instances of Array.


[19]

> *news flash* - problem "solved" wtf. By changing the test to
> creating a bug instead of a question, it works in windmill. Go
> figure. But it works now \o/

Hurrah! And weird. But mostly hurrah :)

-- 
https://code.launchpad.net/~wallyworld/launchpad/improved-broken-link-handling/+merge/37095
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/improved-broken-link-handling into lp:launchpad/devel.