launchpad-reviewers team mailing list archive

[Tim Penhey <tim.penhey@xxxxxxxxxxxxx>]

The proposal to merge lp:~abentley/launchpad/allow-0.3-2 into lp:launchpad has been updated.

Description changed to:

= Summary =
Support bzr-builder recipe format 0.3

== Proposed fix ==
Update the maximim format to 0.3

== Pre-implementation notes ==
None

== Implementation details ==
Various tests and data were updated to 0.3 format.  Now-unnecessary
monkey-patching was removed.  Lint was cleaned up.

== Tests ==
bin/test sourcepackagerecipe

== Demo and Q/A ==
Create a recipe.  It should default to 0.3 format.  Add a nest-part instruction
and save.  The recipe should be accepted, and displayed correctly.  Request a
build of the recipe.  The build should succeed.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/sampledata/current.sql
  database/sampledata/current-dev.sql
  lib/lp/code/model/sourcepackagerecipedata.py
  database/schema/comments.sql
  lib/lp/code/model/tests/test_sourcepackagerecipe.py
  lib/lp/testing/__init__.py
  utilities/sourcedeps.conf
  lib/lp/code/browser/tests/test_sourcepackagerecipe.py
  lib/lp/code/interfaces/sourcepackagerecipe.py
  lib/lp/code/model/tests/test_recipebuilder.py
  database/schema/patch-2208-99-0.sql

./lib/lp/code/model/sourcepackagerecipedata.py
     189: E202 whitespace before ')'
./lib/lp/testing/__init__.py
     129: 'anonymous_logged_in' imported but unused
     129: 'with_anonymous_login' imported but unused
     129: 'is_logged_in' imported but unused
     148: 'launchpadlib_for' imported but unused
     148: 'launchpadlib_credentials_for' imported but unused
     129: 'person_logged_in' imported but unused
     148: 'oauth_access_token_for' imported but unused
     129: 'login_celebrity' imported but unused
     129: 'with_celebrity_logged_in' imported but unused
     147: 'test_tales' imported but unused
     129: 'celebrity_logged_in' imported but unused
     129: 'run_with_login' imported but unused
     129: 'with_person_logged_in' imported but unused
     129: 'login_team' imported but unused
     129: 'login_person' imported but unused
     129: 'login_as' imported but unused
     888: E302 expected 2 blank lines, found 1
     964: E302 expected 2 blank lines, found 1
./database/schema/patch-2208-99-0.sql
       4: Line exceeds 78 characters.
       5: Line exceeds 78 characters.
       6: Line exceeds 78 characters.
       7: Line exceeds 78 characters.


-- 
https://code.launchpad.net/~abentley/launchpad/allow-0.3-2/+merge/39562
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/allow-0.3-2 into lp:launchpad.