launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

The proposal to merge lp:~benji/launchpad/bug-669701 into lp:launchpad has been updated.

Description changed to:

When saving the features flag rules the user is given no indication that
anything actually happened (bug 669701).  This branch fixes that by
adding a message and displaying the changes applied in the form of a
diff.

This branch also fixes a bug discovered during development: if a user
who is not authorized to make feature flag changes attempts to do so a
NameError will be raised because of a missing import in untested code.
Both the import and a test were added.

The tests for the modified code can be run with:

    bin/test -c lp.services.features.browser

The feature can be interactively tested by starting a dev Launchpad
instance and logging in as an admin user (foo.bar@xxxxxxxxxxxxx/test)
will work and then interacting with https://launchpad.dev/+feature-rules.

Several bits of lint were also fixed on this branch.



For more details, see:
https://code.launchpad.net/~benji/launchpad/bug-669701/+merge/45171
-- 
https://code.launchpad.net/~benji/launchpad/bug-669701/+merge/45171
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~benji/launchpad/bug-669701 into lp:launchpad.