launchpad-reviewers team mailing list archive

[Leonard Richardson <leonard.richardson@xxxxxxxxxxxxx>]

Leonard Richardson has proposed merging lp:~leonardr/launchpad/launchpadlib-integration into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~leonardr/launchpad/launchpadlib-integration/+merge/45174

This branch makes some minor changes to launchpadlib that I made while integrating my branch https://code.launchpad.net/~leonardr/launchpadlib/separate-login-for-cronjob into Launchpad.

* Bumped the version number.
* Removed a doctest of login(), since the method is deprecated (and it now has a unit test).
* Made the TestableLaunchpad class provide default values for credential_store and authorization_engine.
* Changed the KnownTokens convenience class to pass in a Credentials object into the TestableLaunchpad constructor, rather than using the now-deprecated login() method.
-- 
https://code.launchpad.net/~leonardr/launchpad/launchpadlib-integration/+merge/45174
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~leonardr/launchpad/launchpadlib-integration into lp:launchpad.

=== modified file 'lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt'
--- lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt	2010-08-12 16:40:04 +0000
+++ lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt	2011-01-04 21:14:18 +0000
@@ -48,7 +48,8 @@
 scheme which does not work in the test environment.
 
     >>> from launchpadlib.launchpad import Launchpad
-    >>> launchpad = Launchpad(credentials, 'http://api.launchpad.dev/')
+    >>> launchpad = Launchpad(
+    ...     credentials, None, None, 'http://api.launchpad.dev/')
     >>> print launchpad.me.name
     no-priv
 
@@ -94,7 +95,8 @@
 Now create a Launchpad object and observe how it populates the cache.
 
     >>> launchpad = Launchpad(
-    ...     credentials, 'http://api.launchpad.dev/', cache=cache)
+    ...     credentials, None, None, 'http://api.launchpad.dev/',
+    ...     cache=cache)
     send: 'GET /1.0/ ...accept: application/vnd.sun.wadl+xml...'
     reply: 'HTTP/1.0 200 Ok\n'
     ...
@@ -106,7 +108,8 @@
 used instead of new HTTP requests being used.
 
     >>> launchpad = Launchpad(
-    ...     credentials, 'http://api.launchpad.dev/', cache=cache)
+    ...     credentials, None, None, 'http://api.launchpad.dev/',
+    ...     cache=cache)
 
 Cleanup.
 

=== modified file 'lib/lp/testing/_webservice.py'
--- lib/lp/testing/_webservice.py	2010-12-17 23:59:00 +0000
+++ lib/lp/testing/_webservice.py	2011-01-04 21:14:18 +0000
@@ -145,7 +145,8 @@
     version = version or Launchpad.DEFAULT_VERSION
     cache = tempfile.mkdtemp(prefix='launchpadlib-cache-')
     zope.testing.cleanup.addCleanUp(_clean_up_cache, (cache,))
-    return Launchpad(credentials, service_root, version=version, cache=cache)
+    return Launchpad(credentials, None, None, service_root=service_root,
+                     version=version, cache=cache)
 
 
 class QueryCollector:

=== modified file 'setup.py'
--- setup.py	2010-12-01 11:26:57 +0000
+++ setup.py	2011-01-04 21:14:18 +0000
@@ -47,6 +47,8 @@
         'lazr.testing',
         'lazr.uri',
         'lazr-js',
+        # Required for launchpadlib
+        'keyring',
         'manuel',
         'mechanize',
         'meliae',

=== modified file 'versions.cfg'
--- versions.cfg	2010-12-10 20:22:14 +0000
+++ versions.cfg	2011-01-04 21:14:18 +0000
@@ -24,7 +24,8 @@
 grokcore.component = 1.6
 httplib2 = 0.6.0
 ipython = 0.9.1
-launchpadlib = 1.6.5
+keyring = 0.5
+launchpadlib = 1.9.0
 lazr.authentication = 0.1.1
 lazr.batchnavigator = 1.2.2
 lazr.config = 1.1.3
@@ -32,7 +33,7 @@
 lazr.enum = 1.1.2
 lazr.lifecycle = 1.1
 lazr.restful = 0.15.0
-lazr.restfulclient = 0.10.0
+lazr.restfulclient = 0.11.1
 lazr.smtptest = 1.1
 lazr.testing = 0.1.1
 lazr.uri = 1.0.2