launchpad-reviewers team mailing list archive

[Huw Wilkins <huwshimi@xxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/highlight-links-367877 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/highlight-links-367877/+merge/45947

Fixed bug #367877: Removed outline reset on links in CSS.
You should now be able to tab between links and your browser will highlight them. This is fixed for Main launchpad, and also for the Tour (which uses a separate stylesheet).
-- 
https://code.launchpad.net/~huwshimi/launchpad/highlight-links-367877/+merge/45947
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/highlight-links-367877 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css.in'
--- lib/canonical/launchpad/icing/style-3-0.css.in	2010-12-17 19:16:54 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css.in	2011-01-12 00:46:31 +0000
@@ -254,9 +254,6 @@
    Universal presentation
    Inline elements.
 */
-a {
-    outline: none;
-    }
 :link, :visited {
     /* Links are blue, brighter when clicked, and greyer once visited. */
     color: #03a;

=== modified file 'lib/canonical/launchpad/tour/launchpad-tour.css'
--- lib/canonical/launchpad/tour/launchpad-tour.css	2009-06-12 16:36:02 +0000
+++ lib/canonical/launchpad/tour/launchpad-tour.css	2011-01-12 00:46:31 +0000
@@ -10,7 +10,6 @@
 a {
 color:#159cc8;
 text-decoration:none;
-outline:none;
 }
 
 strong {
@@ -124,14 +123,14 @@
 height:22px;
 background:url(images/btn-next.png) no-repeat;
 padding:5px 0px 0px 10px;
-margin-right:18px;
-}
-
-
-
-li.button-prev {
-float: left;
-}
+margin-right:18px;
+}
+
+
+
+li.button-prev {
+float: left;
+}
 
 li.button-prev a {
 display:block;
@@ -273,11 +272,11 @@
 background:none;
 padding:2px 0;
 }
-
-#further-information li {
-list-style-type: disc;
-list-style-position: inside;
-}
+
+#further-information li {
+list-style-type: disc;
+list-style-position: inside;
+}
 
 .furthur-information-block-mid ul.further-links li a {
 padding-right:10px;
@@ -321,8 +320,8 @@
 
 li.button-next a:hover {
 background-position:0px -31px;
-}
-
+}
+
 li.button-prev a:hover {
 background-position:0px -31px;
 }
@@ -332,12 +331,12 @@
 padding-bottom: 1em;
 font-size: 8pt;
 text-align:right;
-}
-
-#left-link-holder {
-float: left; 
-margin: 0 20px; 
-padding-bottom: 1em; 
-font-size: 8pt;
-text-align: left;
-}
+}
+
+#left-link-holder {
+float: left; 
+margin: 0 20px; 
+padding-bottom: 1em; 
+font-size: 8pt;
+text-align: left;
+}