launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~ursinha/launchpad/auto-approve into lp:launchpad has been updated.

Description changed to:

These changes implement ec2 land capability to work with the new Launchpad Tarmac merge workflow.

= Summary =

This branch adds the -T (--use-tarmac) option to ec2 land, so when the tests finish, one "tests" vote is added to the merge proposal, and its queue status is set to approved or rejected.
For this to work, I had to add a --mergeproposal-address to ec2 test, considering ec2 land is just a wrapper that generates an ec2 test command line and runs it as a subprocess.

== Tests ==

I've tested the newly created method by adding more tests to test_autoland.py.

./bin/test -vvt devscripts.*

== Demo and Q/A ==

I've tested by running the command in a real merge proposal in Launchpad, using the --dry-run option, to check if the command line is correctly generated by ec2 land.

$ ec2 land <merge_proposal> --force --dry-run --use-tarmac

Should show the command line with the ec2 test --mergeproposal-address I've added so it can generate the signed message to send launchpad after the tests.



For more details, see:
https://code.launchpad.net/~ursinha/launchpad/auto-approve/+merge/45850
-- 
https://code.launchpad.net/~ursinha/launchpad/auto-approve/+merge/45850
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~ursinha/launchpad/auto-approve into lp:launchpad.