launchpad-reviewers team mailing list archive

[Edwin Grubbs <edwin.grubbs@xxxxxxxxxxxxx>]

Review: Approve code
Hi Steve,

Thanks for making the changes. The only thing that you might want to consider is converting the list of email addresses to set objects so that assertEqual() doesn't fail if they are re-ordered for some reason.

-Edwin
-- 
https://code.launchpad.net/~stevenk/launchpad/bpb-currentcomponent-assertion-part-5/+merge/46852
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/bpb-currentcomponent-assertion-part-5 into lp:launchpad.