launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Brad Crittenden has proposed merging lp:~bac/launchpad/bug-705594 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~bac/launchpad/bug-705594/+merge/46970

= Summary =

Redflash target for display_error is wrong in some cases.

== Proposed fix ==

Fix the target.  Think about removing redflash in the future.

== Pre-implementation notes ==

Talk with Benji.

== Implementation details ==

As above.

== Tests ==

* None *

== Demo and Q/A ==

On lp.dev select 'link a related branch', search for a branch but don't
select it.  Before selecting, kill the server so that the selection
fails.  Look to see the correct target is flashed when the branch is
selected.
-- 
https://code.launchpad.net/~bac/launchpad/bug-705594/+merge/46970
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/bug-705594 into lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
--- lib/lp/bugs/javascript/bugtask_index.js	2011-01-14 12:50:23 +0000
+++ lib/lp/bugs/javascript/bugtask_index.js	2011-01-20 20:41:52 +0000
@@ -627,7 +627,7 @@
         link_branch_link.toggleClass('update-in-progress-message');
     };
     error_handler.showError = function(error_msg) {
-        Y.lp.app.errors.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
+        Y.lp.app.errors.display_error(Y.one('.menu-link-addbranch'), error_msg);
     };
 
     function get_branch_and_link_to_bug(data) {
@@ -669,7 +669,7 @@
         link_branch_link.toggleClass('update-in-progress-message');
     };
     error_handler.showError = function(error_msg) {
-        Y.lp.app.errors.display_error(Y.one('.menu-link-addsubscriber'), error_msg);
+        Y.lp.app.errors.display_error(Y.one('.menu-link-addbranch'), error_msg);
     };
 
     // Call linkBranch() on the bug.