launchpad-reviewers team mailing list archive

[Martin Pool <mbp@xxxxxxxxxxxxxx>]

Thanks for addressing this bug. 

To me those explanations don't add a lot beyond the name of the variable.  

For instance 
  'shows branch merge queues if non-empty'
if the bmq is non-empty? 

>From looking at the usage of the flags it looks like this means "shows them if the flag is boolean true", and the values are not the strings 'empty' and 'nonempty' but rather you can use any string, which Python will treat as true?

I think that shows we badly need a standard way to express boolean flags.

I would document them as

  if true (a non-empty string), shows the branch merge queue user interface

  if true (a non-empty string), show incremental diffs on merge proposals
-- 
https://code.launchpad.net/~wgrant/launchpad/bug-708999-ff-docs/+merge/49758
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/bug-708999-ff-docs into lp:launchpad.