launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/bug-708999-ff-docs into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #708999 code.branchmergequeue, code.incremental_diffs.enabled feature flags not documented
  https://bugs.launchpad.net/bugs/708999

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/bug-708999-ff-docs/+merge/49758

This branch fixes bug #708999 by documenting the two undocumented feature flags.

It also cleans and reformats the value domains and descriptions of several other flags to be more consistent and informative.
-- 
https://code.launchpad.net/~wgrant/launchpad/bug-708999-ff-docs/+merge/49758
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/bug-708999-ff-docs into lp:launchpad.

=== modified file 'lib/lp/services/features/flags.py'
--- lib/lp/services/features/flags.py	2011-02-14 18:21:01 +0000
+++ lib/lp/services/features/flags.py	2011-02-15 03:09:55 +0000
@@ -20,9 +20,17 @@
 # This table of flag name, value domain, and prose documentation is used to
 # generate the web-visible feature flag documentation.
 flag_info = sorted([
+    ('code.branchmergequeue',
+     '[empty|nonempty]',
+     'shows branch merge queues if non-empty',
+     ''),
+    ('code.incremental_diffs.enabled',
+     '[empty|nonempty]',
+     'shows incremental diffs on merge proposals if non-empty',
+     ''),
     ('code.recipes_enabled',
      '[on|off]',
-     'enable recipes',
+     'enables recipes',
      'off'),
     ('hard_timeout',
      'float',
@@ -34,19 +42,19 @@
      'off'),
     ('malone.disable_targetnamesearch',
      '[empty|nonempty]',
-     'If nonempty targetnames are not consulted during text search.',
+     'disables consultation of target names during text search if non-empty',
      ''),
     ('memcache',
      '[enabled|disabled]',
-     'enables/disables memcache',
+     'enables memcache',
      'enabled'),
     ('publicrestrictedlibrarian',
      '[on|off]',
-     'redirect to private URLs instead of proxying',
+     'redirects to private URLs instead of proxying',
      'off'),
     ('visible_render_time',
-     'empty|nonempty',
-     'enables showing the page render overheads in the login widget',
+     '[empty|nonempty]',
+     'shows the page render time in the login widget if non-empty',
      ''),
     ])