launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

John--

I can't say I'm 100% comfortable with approving this, given there's no tests. fork configurations and processes have already caused on incident report, so I think we need more confidence that this works as intended before approving it.

I'm not claiming this as a review, b/c you might find someone who knows more about the problem area and can approve this with some confidence. I do urge you to look into testing options for it; that might not be test coverage, but we should see how this code works in some fashion.
-- 
https://code.launchpad.net/~jameinel/launchpad/lp-forking-serve-cleaner-childre/+merge/50031
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jameinel/launchpad/lp-forking-serve-cleaner-childre into lp:launchpad.