launchpad-reviewers team mailing list archive

[Henning Eggers <henning.eggers@xxxxxxxxxxxxx>]

Review: Approve ui
Hi Ian,
this looks good and I had actually stumbled on this problem when reviewing your last work. Thanks for addressing this.

Although, IF you have the information present when creating the dialog it would be waaaaaay cooler if the distroseries for which pending builds exist are grayed out, so that the user cannot trigger an error here so easily. (It may still happen if a daily build gets scheduled while the dialog is open.) I realize, though, that this may be a bit more difficult since this also depends on the selected PPA.

Henning

-- 
https://code.launchpad.net/~wallyworld/launchpad/recipe-request-build-partial-success/+merge/50873
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/recipe-request-build-partial-success into lp:launchpad.