launchpad-reviewers team mailing list archive

[John A Meinel <john@xxxxxxxxxxxxxxxxx>]

John A Meinel has proposed merging lp:~jameinel/launchpad/use_loggerhead_trunk into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jameinel/launchpad/use_loggerhead_trunk/+merge/52062

This updates the sourcecode dependency, so that we will use loggerhead's trunk branch rather than the old ~launchpad-pqm/loggerhead/devel branch. It also updates it to use the current trunk revision (431).

I'm proposing it this way, because it sounded like how Robert wanted the transition to happen. Make loggerhead trunk stable, start using it as the deployment source.

Changes vs current deployed revision:

423) Merged pqm into trunk

424) HEAD requests don't render the template. Saves a small amount of time for HEAD requests, mostly makes them conform to HTTP rules, of not sending body content for a HEAD request.

425) Code cleanup, drop bzr compatibility code for bzr <=1.16. 

426) Testing infrastructure code

427) Fix the test suite

428) Debian compatibility, when bzrlib.util.configobj is not present, because we use the system-wide installation of configobj. Shouldn't matter for deployment.

429) Updated CSS to make Loggerhead conform to Launchpad's style. Fairly large UI change, but seems to have been approved by all the right people.

430) Stop supporting pure "json" in favor of requiring "simplejson". We had buggy support for just "json". Rather than trying to fix it, just remove support for it. Should not effect the deployed version.

431) Use a special favicon when browsing "between" branches. Should also not affect deployed loggerhead. Because deployed version doesn't let you go to, eg http://bazaar.launchpad.net/~bzr-pqm/bzr/ and see the list of branches. (Versus standalone version which would.)

Overall, this seems reasonable to get us running from trunk, with a few bug fixes, and prepares the way as we start landing more updates to the loggerhead codebase.

-- 
https://code.launchpad.net/~jameinel/launchpad/use_loggerhead_trunk/+merge/52062
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jameinel/launchpad/use_loggerhead_trunk into lp:launchpad.

=== modified file 'utilities/sourcedeps.conf'
--- utilities/sourcedeps.conf	2011-02-25 10:39:53 +0000
+++ utilities/sourcedeps.conf	2011-03-03 13:03:19 +0000
@@ -6,7 +6,7 @@
 cscvs lp:~launchpad-pqm/launchpad-cscvs/devel;revno=432
 dulwich lp:~launchpad-pqm/dulwich/devel;revno=424
 difftacular lp:difftacular;revno=6
-loggerhead lp:~launchpad-pqm/loggerhead/devel;revno=178
+loggerhead lp:~loggerhead-team/loggerhead/trunk-rich;revno=431
 lpreview lp:~launchpad-pqm/bzr-lpreview/devel;revno=23
 mailman lp:~launchpad-pqm/mailman/2.1;revno=976
 old_xmlplus lp:~launchpad-pqm/dtdparser/trunk;revno=4