launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Brad Crittenden has proposed merging lp:~bac/launchpad/remove-old-devmode-js into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~bac/launchpad/remove-old-devmode-js/+merge/56400

= Summary =

We no longer build individual JS files in icing but many page templates
attempt to load them but only when in devmode.  The failure doesn't hurt
anything but it does show up in the server console which doesn't inspire
confidence.

== Proposed fix ==

Rip them out.

== Pre-implementation notes ==

Chat with Deryck on IRC.

== Implementation details ==

As above.

== Tests ==

None.

== Demo and Q/A ==

Use 'Report a bug' and ensure the filebug-dupefinder.js "not found"
error isn't printed in the LP server console.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/soyuz/templates/archive-delete-packages.pt
  lib/lp/registry/templates/distributionsourcepackage-index.pt
  lib/lp/soyuz/templates/archive-copy-packages.pt
  lib/lp/bugs/templates/official-bug-target-manage-tags.pt
  lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt
  lib/lp/bugs/templates/bugtarget-filebug-search.pt
  lib/lp/bugs/templates/bug-subscription.pt
-- 
https://code.launchpad.net/~bac/launchpad/remove-old-devmode-js/+merge/56400
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/remove-old-devmode-js into lp:launchpad.

=== modified file 'lib/lp/bugs/templates/bug-subscription.pt'
--- lib/lp/bugs/templates/bug-subscription.pt	2011-03-23 16:28:51 +0000
+++ lib/lp/bugs/templates/bug-subscription.pt	2011-04-05 16:15:50 +0000
@@ -14,10 +14,6 @@
     <script type="text/javascript"
             tal:condition="devmode"
             tal:content="string:var yui_base='${yui}';"></script>
-    <script type="text/javascript"
-            tal:condition="devmode"
-            tal:define="lp_js string:${icingroot}/build"
-            tal:attributes="src string:${lp_js}/bugs/filebug-dupefinder.js"></script>
 
     <script type="text/javascript" tal:condition="view/user_is_muted">
         LPS.use('base', 'node', 'oop', 'event', 'lp.bugs.bug_subscription',

=== modified file 'lib/lp/bugs/templates/bugtarget-filebug-search.pt'
--- lib/lp/bugs/templates/bugtarget-filebug-search.pt	2010-12-09 19:51:06 +0000
+++ lib/lp/bugs/templates/bugtarget-filebug-search.pt	2011-04-05 16:15:50 +0000
@@ -9,10 +9,6 @@
     <script type="text/javascript"
             tal:condition="devmode"
             tal:content="string:var yui_base='${yui}';"></script>
-    <script type="text/javascript"
-            tal:condition="devmode"
-            tal:define="lp_js string:${icingroot}/build"
-            tal:attributes="src string:${lp_js}/bugs/filebug-dupefinder.js"></script>
 
     <script type="text/javascript"
             tal:condition="context/enable_bugfiling_duplicate_search">

=== modified file 'lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt'
--- lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt	2010-10-10 21:54:16 +0000
+++ lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt	2011-04-05 16:15:50 +0000
@@ -9,10 +9,6 @@
     <script type="text/javascript"
             tal:condition="devmode"
             tal:content="string:var yui_base='${yui}';"></script>
-    <script type="text/javascript"
-            tal:condition="devmode"
-            tal:define="lp_js string:${icingroot}/build"
-            tal:attributes="src string:${lp_js}/bugs/filebug-dupefinder.js"></script>
     <script type="text/javascript">
       LPS.use('base', 'node', 'oop', 'event', 'lp.bugs.filebug_dupefinder',
       function(Y) {

=== modified file 'lib/lp/bugs/templates/official-bug-target-manage-tags.pt'
--- lib/lp/bugs/templates/official-bug-target-manage-tags.pt	2010-10-10 21:54:16 +0000
+++ lib/lp/bugs/templates/official-bug-target-manage-tags.pt	2011-04-05 16:15:50 +0000
@@ -21,10 +21,6 @@
             <div metal:use-macro="context/@@launchpad_form/form" />
         </noscript>
 
-        <script type="text/javascript"
-                tal:define="lp_js string:${icingroot}/build"
-                tal:attributes="src string:${lp_js}/bugs/offical_bug_tags.js">
-        </script>
         <script tal:replace="structure view/tags_js_data" />
         <script type="text/javascript">
             LPS.use('event', 'lp.bugs.official_bug_tags', function(Y) {
@@ -97,7 +93,7 @@
           <tr>
             <td class="actions" colspan="3">
               <input type="submit" value="Save" id="save-button" disabled="true" />
-              or <a id="cancel-link" tal:attributes="href view/cancel_url">Cancel</a>        
+              or <a id="cancel-link" tal:attributes="href view/cancel_url">Cancel</a>
             </td>
           </tr>
         </table>

=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt	2011-03-29 22:34:04 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt	2011-04-05 16:15:50 +0000
@@ -10,12 +10,6 @@
 <body>
 
 <metal:block fill-slot="head_epilogue">
-  <tal:devmode condition="devmode">
-    <tal:archive_js define="lp_js string:${icingroot}/build">
-      <script type="text/javascript"
-              tal:attributes="src string:${lp_js}/soyuz/base.js"></script>
-    </tal:archive_js>
-  </tal:devmode>
   <script type="text/javascript"
       tal:condition="
         request/features/malone.advanced-structural-subscriptions.enabled">

=== modified file 'lib/lp/soyuz/templates/archive-copy-packages.pt'
--- lib/lp/soyuz/templates/archive-copy-packages.pt	2011-01-28 04:08:32 +0000
+++ lib/lp/soyuz/templates/archive-copy-packages.pt	2011-04-05 16:15:50 +0000
@@ -8,16 +8,6 @@
   >
 <body>
 
-<metal:block fill-slot="head_epilogue">
-  <tal:devmode condition="devmode">
-    <tal:archive_js define="lp_js string:${icingroot}/build">
-      <script type="text/javascript"
-              tal:attributes="src string:${lp_js}/soyuz/base.js">
-      </script>
-    </tal:archive_js>
-  </tal:devmode>
-</metal:block>
-
 <div metal:fill-slot="main">
   <div class="top-portlet">
     <tal:cannot_copy condition="not: view/can_copy">

=== modified file 'lib/lp/soyuz/templates/archive-delete-packages.pt'
--- lib/lp/soyuz/templates/archive-delete-packages.pt	2011-01-28 04:08:32 +0000
+++ lib/lp/soyuz/templates/archive-delete-packages.pt	2011-04-05 16:15:50 +0000
@@ -8,16 +8,6 @@
   >
 <body>
 
-<metal:block fill-slot="head_epilogue">
-  <tal:devmode condition="devmode">
-    <tal:archive_js define="lp_js string:${icingroot}/build">
-      <script type="text/javascript"
-              tal:attributes="src string:${lp_js}/soyuz/base.js">
-      </script>
-    </tal:archive_js>
-  </tal:devmode>
-</metal:block>
-
 <div metal:fill-slot="main">
 <div class="top-portlet">
     <tal:inactive_ppa_header condition="not: view/has_sources">