launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #03205
[Merge] lp:~gmb/launchpad/bug-1-timeout into lp:launchpad
Graham Binns has proposed merging lp:~gmb/launchpad/bug-1-timeout into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~gmb/launchpad/bug-1-timeout/+merge/56407
This branch changes the default for the include_parents parameter on Bug._indexed_message() to False, so that it matches the declaration on IBug._indexed_message(). There is a possibility that this will fix bug 744888, but I won't be able to tell until this has landed.
It doesn't, however, cause any test failures, which is at least something.
--
https://code.launchpad.net/~gmb/launchpad/bug-1-timeout/+merge/56407
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gmb/launchpad/bug-1-timeout into lp:launchpad.
=== modified file 'lib/lp/bugs/model/bug.py'
--- lib/lp/bugs/model/bug.py 2011-04-05 06:13:17 +0000
+++ lib/lp/bugs/model/bug.py 2011-04-05 16:49:12 +0000
@@ -452,7 +452,7 @@
# value (in the absence of slices)
return self._indexed_messages(include_content=True)
- def _indexed_messages(self, include_content=False, include_parents=True):
+ def _indexed_messages(self, include_content=False, include_parents=False):
"""Get the bugs messages, indexed.
:param include_content: If True retrieve the content for the messages