← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~mbp/launchpad/778437-sprb-spam into lp:launchpad

 

A thought: tests exist to guarantee behavior.  If the behavior of not sending an email on build success is important and not too hard to do (risk:cost ratio), then it would be a win to have a test.  On the other hand, if we're not too worried about this bug being reintroduced or the cost of it being reintroduced is very low, then even a small cost of writing the test might be too much.
-- 
https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/778437-sprb-spam into lp:launchpad.


References