launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Benji York has proposed merging lp:~benji/launchpad/remove-click-to-close into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~benji/launchpad/remove-click-to-close/+merge/60673

This branch removes the broken click-to-close message box functionality.  No fix for bug 779538 could be found within a reasonable time box (lp:~benji/launchpad/bug-779538 was deemed unsuitable in review).

The make lint report is clean.
-- 
https://code.launchpad.net/~benji/launchpad/remove-click-to-close/+merge/60673
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~benji/launchpad/remove-click-to-close into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2011-05-04 14:33:48 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2011-05-11 18:14:48 +0000
@@ -994,7 +994,7 @@
     border-width: 1px 2px 2px 1px;
     color: black;
     margin: 1em auto 1em auto;
-    padding: 0.3em 1em 1.6em 2em;
+    padding: 0 1em 1em 2em;
     width: 30em;
     }
 .error.message::before, .warning.message::before,
@@ -1017,23 +1017,6 @@
 .warning.message::before {
     content: url(/@@/warning-large);
     }
-.error.message::after, .warning.message::after,
-.informational.message::after {
-    /* Add an affordance that suggests the ability to hide the message. */
-    /* The NBSP (\00A0) is needed because of the margin trick below. */
-    content: 'Hide\00A0\2715';
-    float: right;
-    display: block;
-    margin-left: 999em; /* Assure the message is always "bumped" down. */
-    }
-.error.message:hover::after, .warning.message:hover::after,
-.informational.message:hover::after {
-    text-decoration: underline;
-    }
-.error.message:hover, .warning.message:hover,
-.informational.message:hover {
-    cursor: pointer;
-}
 .informational {
     /* Informational messages are blue-to-grey, alerts have an info icon. */
 

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2011-05-03 17:53:50 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2011-05-11 18:14:48 +0000
@@ -125,12 +125,6 @@
         // anywhere outside of it.
         Y.on('click', handleClickOnPage, window);
 
-        // Hook up an event hanlder that will close any message boxes when they
-        // are clicked.
-        Y.delegate('click', function(e) {
-            this.setStyle('display', 'none');
-        }, 'body', '.message');
-
         Y.on('lp:context:web_link:changed', function(e) {
             window.location = e.new_value;
         });