launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/edit-subscription-always-loading-781245 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #781245 in Launchpad itself: "Clicking "Edit subscription" when subscribed via a duplicate gets stuck at "Loading...""
  https://bugs.launchpad.net/launchpad/+bug/781245

For more details, see:
https://code.launchpad.net/~deryck/launchpad/edit-subscription-always-loading-781245/+merge/60683

When being subscribed to a bug via a duplicate, the "Edit Subscription" link will never finish loading.  This is because the contentready event handler was listening for contentready on a node that can only be found in the bug subscription notification level form.  This branch fixes that by updating the CSS selector to catch both the notification level form and the generic "unsubscribe from bug" form.

I used the hiddenType class on the "unsubscribe from bug" form, since that seemed to be the only element I could grab.  All the IDs in the form use the zope forms "field.foo" form, which doesn't play well with YUI3.
-- 
https://code.launchpad.net/~deryck/launchpad/edit-subscription-always-loading-781245/+merge/60683
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/edit-subscription-always-loading-781245 into lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/bugtask_index_portlets.js'
--- lib/lp/bugs/javascript/bugtask_index_portlets.js	2011-05-10 22:06:27 +0000
+++ lib/lp/bugs/javascript/bugtask_index_portlets.js	2011-05-11 19:31:06 +0000
@@ -707,7 +707,7 @@
 
     Y.on('contentready', function() {
         Y.lp.bugs.bug_notification_level.setup();
-    }, '.bug-notification-level-field');
+    }, '.bug-notification-level-field, .hiddenType');
 
     // Show the overlay when the special event indicating that the form is
     // ready to be displayed is received.