launchpad-reviewers team mailing list archive

[Raphaël Victor Badin <raphael.badin@xxxxxxxxxxxxx>]

This looks good to me.

For the record: basically no intelligent perm checking is done on the js side: if a js button/link is present, it's connected up with Javascript. The perm checking is a) in the template which will only generate appropriate buttons/link b) on the backend side when a js action reaches the server.

[1]

Looks there is a windmill test for adding comments ... I'm unsure what we should do with it but I'm sure you will know :)

lib/lp/registry/windmill/tests/test_distroseriesdifference_expander.py

[2]

I have a few lint suggestions to make 'make lint' (almost) happy: http://paste.ubuntu.com/623551/

Thanks for correcting this bug!
-- 
https://code.launchpad.net/~allenap/launchpad/compute-differences-wiring-bug-795448/+merge/64194
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/compute-differences-wiring-bug-795448 into lp:launchpad.