launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

> This looks good to me.

Thank you for the review :)

> For the record: basically no intelligent perm checking is done on the js side:
> if a js button/link is present, it's connected up with Javascript. The perm
> checking is a) in the template which will only generate appropriate
> buttons/link b) on the backend side when a js action reaches the server.

Yes, agreed.

> [1]
> 
> Looks there is a windmill test for adding comments ... I'm unsure what we
> should do with it but I'm sure you will know :)

Nuke from orbit? ;)

I can't actually run this; the test runner complains about
profiles. For the record:

{{{
Traceback (most recent call last):
  File ".../eggs/zope.testing-3.9.4_p3-py2.6.egg/zope/testing/testrunner/runner.py", line 367, in run_layer
    setup_layer(options, layer, setup_layers)
  File ".../eggs/zope.testing-3.9.4_p3-py2.6.egg/zope/testing/testrunner/runner.py", line 648, in setup_layer
    layer.setUp()
  File "/home/gavin/Launchpad/launchpad/compute-differences-wiring-bug-795448/lib/lp/registry/windmill/testing.py", line 25, in setUp
    super(RegistryWindmillLayer, cls).setUp()
  File "/home/gavin/Launchpad/launchpad/compute-differences-wiring-bug-795448/lib/canonical/testing/profiled.py", line 29, in profiled_func
    return func(cls, *args, **kw)
  File "/home/gavin/Launchpad/launchpad/compute-differences-wiring-bug-795448/lib/canonical/testing/layers.py", line 2008, in setUp
    cls.shell_objects = start_windmill()
  File ".../eggs/windmill-1.5pre_deryck-py2.6.egg/windmill/bin/admin_lib.py", line 337, in start_windmill
    shell_objects = setup()
  File ".../eggs/windmill-1.5pre_deryck-py2.6.egg/windmill/bin/admin_lib.py", line 182, in setup
    shell_objects_dict['browser'] = getattr(shell_objects, browser[0].lower())()
  File ".../eggs/windmill-1.5pre_deryck-py2.6.egg/windmill/bin/shell_objects.py", line 45, in start_firefox
    controller = windmill.browser.get_firefox_controller()
  File ".../eggs/windmill-1.5pre_deryck-py2.6.egg/windmill/browser/__init__.py", line 116, in get_firefox_controller
    controller = mozrunner.get_moz_from_settings(copy.copy(windmill.settings))
  File ".../eggs/windmill-1.5pre_deryck-py2.6.egg/windmill/dep/_mozrunner/__init__.py", line 165, in get_moz_from_settings
    cmd_args=settings['MOZILLA_CMD_ARGS'])
  File ".../eggs/windmill-1.5pre_deryck-py2.6.egg/windmill/dep/_mozrunner/__init__.py", line 131, in get_moz
    raise Exception ('No default or local profile has been set.')
Exception: No default or local profile has been set.
}}}

For now, I'm just going to ignore it, but thanks for pointing it out.

> [2]
> 
> I have a few lint suggestions to make 'make lint' (almost) happy:
> http://paste.ubuntu.com/623551/

Tip top, thank you, I've applied it.

-- 
https://code.launchpad.net/~allenap/launchpad/compute-differences-wiring-bug-795448/+merge/64194
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/compute-differences-wiring-bug-795448 into lp:launchpad.