launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/launchpad/localpackagediffs-errant-line-bug-783455 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #783455 in Launchpad itself: "+localpackagediffs errant dividing line in expanded section"
  https://bugs.launchpad.net/launchpad/+bug/783455

For more details, see:
https://code.launchpad.net/~allenap/launchpad/localpackagediffs-errant-line-bug-783455/+merge/64388

Adds a style rule to prevent the top border being shown on expanded difference rows.

To demonstrate, first create a difference to look at:

  $ bin/harness
  >>> diff = factory.makeDistroSeriesDifferenceComment()
  >>> derived_series = diff.distro_series_difference.derived_series
  >>> transaction.commit()
  >>> import webbrowser
  >>> webbrowser.open(canonical_url(
  ...     derived_series, view_name="+localpackagediffs"))

Then open the expander.

-- 
https://code.launchpad.net/~allenap/launchpad/localpackagediffs-errant-line-bug-783455/+merge/64388
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/localpackagediffs-errant-line-bug-783455 into lp:launchpad.

=== modified file 'lib/lp/registry/templates/distroseries-localdifferences.pt'
--- lib/lp/registry/templates/distroseries-localdifferences.pt	2011-05-27 07:50:38 +0000
+++ lib/lp/registry/templates/distroseries-localdifferences.pt	2011-06-13 11:28:32 +0000
@@ -12,6 +12,9 @@
         .distroseries-localdiff-search-filter input[type="radio"] {
           margin-left: 0;
         }
+        /* Don't show a border between the
+           difference rows and their expanded sections */
+        table.listing tr.diff-extra td { border-top: 0; }
       </style>
     </metal:block>