← Back to team overview

launchpad-reviewers team mailing list archive

Re: lp:~jtv/launchpad/pre-bug-791204-getPackageUploads-name-filter into lp:launchpad

 

> So you can file my suggestion under 'you can tell its not much worse
> if it still works with large (2K item) queues on Ubuntu on dogfood.'

FWIW Dogfood won't render that right now, unless I change the timeout *very* high.

The queue page only currently scrapes by on production because of two fairly crappy optimisations:
1. The CompletePackageUpload which collates some aggregate bits of info and delegates the rest to a real PackageUpload.
2. The FK bits that it delegates are pulled in as a side-effect of many other queries using preloads.

So any changes that avoid the existing preloads are fairly doomed.  However, getQueueItems doesn't use preloads so switching it over to the newer Storm code should be OK.
-- 
https://code.launchpad.net/~jtv/launchpad/pre-bug-791204-getPackageUploads-name-filter/+merge/64345
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/pre-bug-791204-getPackageUploads-name-filter into lp:launchpad.


References