launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/table-headings-728187 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/table-headings-728187/+merge/66008


-- 
https://code.launchpad.net/~huwshimi/launchpad/table-headings-728187/+merge/66008
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/table-headings-728187 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2011-06-17 17:33:14 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2011-06-27 15:44:30 +0000
@@ -518,6 +518,7 @@
 th, td {
     vertical-align: baseline;
     }
+.head th,
 thead th, tr.thead th {
     text-align: left;
     vertical-align: bottom;
@@ -624,6 +625,7 @@
 table.listing th {
     font-weight: bold;
     }
+table.listing .head, table.listing .head th,
 table.listing thead, table.listing thead th, table.listing tfoot tr,
 table.listing tr.thead th {
     border: 1px solid #d2d2d2;

=== modified file 'lib/lp/registry/templates/distributionmirror-macros.pt'
--- lib/lp/registry/templates/distributionmirror-macros.pt	2010-12-16 20:40:07 +0000
+++ lib/lp/registry/templates/distributionmirror-macros.pt	2011-06-27 15:44:30 +0000
@@ -16,16 +16,14 @@
   <table class="listing" id="mirrors_list">
   <tbody>
     <tal:country_and_mirrors repeat="country_and_mirrors mirrors_by_country">
-      <tr class="highlight">
-        <th colspan="2" style="text-align: left"
+      <tr class="head">
+        <th colspan="2" 
             tal:content="country_and_mirrors/country" />
-        <th style="text-align: left"
-            tal:content="country_and_mirrors/throughput"/>
-        <th style="text-align: left" tal:condition="show_mirror_type">
+        <th tal:content="country_and_mirrors/throughput"/>
+        <th tal:condition="show_mirror_type">
           Type
         </th>
-        <th style="text-align: left"
-            tal:define="mirror_count country_and_mirrors/number">
+        <th tal:define="mirror_count country_and_mirrors/number">
           <tal:count replace="mirror_count" />
           <span tal:condition="python:mirror_count == 1">mirror</span>
           <span tal:condition="python:mirror_count != 1">mirrors</span>
@@ -59,20 +57,22 @@
         Include a blank row after the last entry of a country to provide
         vertical spacing to separate the next country.
       </tal:comment>
-      <tr class="lesser">
+      <tr>
+        <td>&nbsp;</td>
+        <td>&nbsp;</td>
+        <td>&nbsp;</td>
         <td>&nbsp;</td>
       </tr>
 
     </tal:country_and_mirrors>
-    <tr class="highlight">
-      <th colspan="5" style="text-align: left; font-weight: bold;">Total</th>
+    <tr class="head">
+      <th colspan="5" >Total</th>
     </tr>
     <tr>
       <td colspan="2" />
-      <td style="text-align: left; font-weight: bold;"
-          tal:content="total_throughput" />
+      <td tal:content="total_throughput" />
       <td tal:condition="show_mirror_type"></td>
-      <td style="text-align: left; font-weight: bold;">
+      <td>
           <tal:count replace="total_mirror_count" />
           <span tal:condition="python:total_mirror_count == 1">mirror</span>
           <span tal:condition="python:total_mirror_count != 1">mirrors</span>