launchpad-reviewers team mailing list archive

[Diogo Matsubara <matsubara@xxxxxxxxxxxxx>]

Diogo Matsubara has proposed merging lp:~matsubara/launchpad/714536-new-recipe-ui into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #714536 in Launchpad itself: "Branch:+new-recipe related branches listing has formatting issues"
  https://bugs.launchpad.net/launchpad/+bug/714536

For more details, see:
https://code.launchpad.net/~matsubara/launchpad/714536-new-recipe-ui/+merge/66010

This branch fixes bug 714536:
- s/Related Branches/Related branches/;
- Removes the space between Related branches link and the header by changing the margin-top for the collapsible to 0;
- Fix the table heading and rows bottom padding;

I left out the change to remove the series column from the table as it links to the series. I could remove that if that's desirable.
-- 
https://code.launchpad.net/~matsubara/launchpad/714536-new-recipe-ui/+merge/66010
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~matsubara/launchpad/714536-new-recipe-ui into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2011-06-17 17:33:14 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2011-06-27 15:51:13 +0000
@@ -892,6 +892,10 @@
 table.form table.extra-options th {
     padding-bottom: 1em;
     }
+table.form table.listing th,
+table.form table.listing td {
+    padding-bottom: 0.25em;
+}
 table.form td td {
     padding-bottom: 0;
     }
@@ -914,6 +918,9 @@
     margin: 0;
     padding: 16px 0 0; /* "Add a comment/attachment" form in bug reports */
     }
+fieldset.collapsible h2 {
+    margin-top: 0;
+}
 fieldset .collapsed {
     display: none;
     }

=== modified file 'lib/lp/app/javascript/lp.js'
--- lib/lp/app/javascript/lp.js	2011-04-11 14:15:32 +0000
+++ lib/lp/app/javascript/lp.js	2011-06-27 15:51:13 +0000
@@ -138,7 +138,7 @@
             var legend = collapsible.one('legend');
             if (legend === null) {
                 // If it's null, this might be a collapsible div, not
-                // fieldset, so try to grap the div's "legend".
+                // fieldset, so try to grab the div's "legend".
                 legend = collapsible.one('.config-options');
             }
             if (legend === null ||

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-related-branches.pt'
--- lib/lp/code/templates/sourcepackagerecipe-related-branches.pt	2011-03-04 14:39:42 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-related-branches.pt	2011-06-27 15:51:13 +0000
@@ -4,7 +4,7 @@
               tal:define="seriesBranches view/related_series_branch_info;
                           packageBranches view/related_package_branch_info"
               tal:condition="python: seriesBranches or packageBranches">
-  <legend>Related Branches</legend>
+  <legend>Related branches</legend>
   <div class="extra-options">
 
     <div tal:condition="packageBranches" id="related-package-branches">