launchpad-reviewers team mailing list archive

[Diogo Matsubara <matsubara@xxxxxxxxxxxxx>]

Diogo Matsubara has proposed merging lp:~matsubara/launchpad/724727-single-line-inline-editor into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #724727 in Launchpad itself: "Single-line inline editor causes page to shift when editing"
  https://bugs.launchpad.net/launchpad/+bug/724727

For more details, see:
https://code.launchpad.net/~matsubara/launchpad/724727-single-line-inline-editor/+merge/66089

This branch fixes bug 724727 by overriding margin-top value for .yui3-skin-sam .yui3-ieditor-input class. With this change the single-line inline editor (e.g. recipe title, bug titles) shifts the page just a little bit to accommodate the edit box.
-- 
https://code.launchpad.net/~matsubara/launchpad/724727-single-line-inline-editor/+merge/66089
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~matsubara/launchpad/724727-single-line-inline-editor into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2011-06-27 13:22:42 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2011-06-28 08:26:13 +0000
@@ -955,6 +955,9 @@
 .yui3-ieditor {
     padding-right: 288px;
     }
+.yui3-skin-sam .yui3-ieditor-input {
+    margin-top: 0;
+}
 h1 .yui3-ieditor-errors {
     font-size: 12px;
     }