launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

Данило Шеган has proposed merging lp:~danilo/launchpad/branch-portlet-details-remove into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~danilo/launchpad/branch-portlet-details-remove/+merge/66117

= Remove unused portlet code =

Kill the portlet which is not used anywhere.

== Demo and Q/A ==

If all tests pass, qa-ok.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/browser/configure.zcml
-- 
https://code.launchpad.net/~danilo/launchpad/branch-portlet-details-remove/+merge/66117
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/branch-portlet-details-remove into lp:launchpad.

=== modified file 'lib/lp/code/browser/configure.zcml'
--- lib/lp/code/browser/configure.zcml	2011-05-27 21:03:22 +0000
+++ lib/lp/code/browser/configure.zcml	2011-06-28 11:28:33 +0000
@@ -414,9 +414,6 @@
             name="+index"
             template="../templates/branch-index.pt"/>
         <browser:page
-            name="+portlet-details"
-            template="../templates/branch-portlet-details.pt"/>
-        <browser:page
             name="++bug-links"
             template="../templates/branch-bug-links.pt"/>
 

=== removed file 'lib/lp/code/templates/branch-portlet-details.pt'
--- lib/lp/code/templates/branch-portlet-details.pt	2009-07-17 17:59:07 +0000
+++ lib/lp/code/templates/branch-portlet-details.pt	1970-01-01 00:00:00 +0000
@@ -1,38 +0,0 @@
-<div
-  xmlns:tal="http://xml.zope.org/namespaces/tal";
-  xmlns:metal="http://xml.zope.org/namespaces/metal";
-  xmlns:i18n="http://xml.zope.org/namespaces/i18n";
-  class="portlet" id="portlet-details">
-  <h2>Current details</h2>
-  <div class="portletBody portletContent">
-    <table>
-      <tbody>
-        <tr>
-          <th>Type:</th>
-          <td><tal:branch-type replace="context/branch_type/title" /></td>
-        </tr>
-        <tr tal:condition="not:view/owner_is_registrant">
-          <th>Registrant:</th>
-          <td>
-            <tal:registrant replace="structure context/registrant/fmt:link"/>
-          </td>
-        </tr>
-        <tr tal:condition="context/product">
-          <th>Project:</th>
-          <td>
-            <tal:link replace="structure context/product/fmt:link" />
-          </td>
-        </tr>
-        <tr>
-          <th>Status:</th>
-          <td>
-            <span id="branch-details-status-value"
-                  tal:content="context/lifecycle_status/title"
-                  tal:attributes="class string:branchstatus${context/lifecycle_status/name}"
-                >Experimental</span>
-          </td>
-        </tr>
-      </tbody>
-    </table>
-  </div>
-</div>