launchpad-reviewers team mailing list archive

[Andrew Bennetts <andrew.bennetts@xxxxxxxxxxxxx>]

Andrew Bennetts has proposed merging lp:~spiv/launchpad/bmp-inline-diffs into lp:launchpad with lp:~danilo/launchpad/expander-anim as a prerequisite.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~spiv/launchpad/bmp-inline-diffs/+merge/66634

This still needs some polish, but it's close enough to be worth a review.  It's guarded by a feature flag so it ought to be safe to land as is.

It adds inline dynamic diffs to branch index and merge proposal pages.  It fetches them from loggerhead (proxied via the lpnet webapp).

It's guarded by a feature flag, the jslint is clean, and it has some tests (although it could use more).  I don't think this does anything outrageously wrong, but many of the tools used here are new to me so I could be wrong!  So let me know what you think!
-- 
https://code.launchpad.net/~spiv/launchpad/bmp-inline-diffs/+merge/66634
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~spiv/launchpad/bmp-inline-diffs into lp:launchpad.