launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~spiv/launchpad/bmp-inline-diffs into lp:launchpad

To: Andrew Bennetts <andrew.bennetts@xxxxxxxxxxxxx>
From: Martin Pool <martinpool@xxxxxxxxx>
Date: Wed, 06 Jul 2011 22:43:27 -0000
In-reply-to: <20110701162335.11009.47016.launchpad@loganberry.canonical.com>
Reply-to: mp+66634@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

[tweak] The flag ought to be called foo.enabled

I think this is not going to work for private branches because of <https://bugs.launchpad.net/launchpad/+bug/806713>.  For an initial closed beta we can probably just live with it being broken.  As an interim step, I guess we would have the option of disabling it for private branches.  Eventually we'd need to fix that.
-- 
https://code.launchpad.net/~spiv/launchpad/bmp-inline-diffs/+merge/66634
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~spiv/launchpad/bmp-inline-diffs into lp:launchpad.

References

[Merge] lp:~spiv/launchpad/bmp-inline-diffs into lp:launchpad
From: Andrew Bennetts, 2011-07-01