← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~bryce/launchpad/cronjob-component-deletion into lp:launchpad

 

Nice one.  A shame there's no intermediate between "find" (which returns a result set and is so flexible that it takes several lines to say "the one with this id") and "get" (which looks for a key, but returns a single object).

A very small note: we generally state the short description of a method in the imperative: "Download and return" rather than "Downloads and returns."

Otherwise, good to go!
-- 
https://code.launchpad.net/~bryce/launchpad/cronjob-component-deletion/+merge/67782
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bryce/launchpad/cronjob-component-deletion into lp:launchpad.


References