launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Review: Approve db
Technically, the DB patch is fine.

I think the code is wrong though. If the heat is being recalculated on the same day of the month as the last update, it is decayed, but will bounce back the following time it is recalculated unless you are lucky. And months have uneven number of days, so decay is less likely to kick in if the last update happened on 29th-31st of a month.

If it is correct, it needs a comment explaining the WTF.

What was our rationale for putting this as a stored procedure again? The logic is getting complex and it may be easier to maintain and test the algorithm from normal Python.
-- 
https://code.launchpad.net/~deryck/launchpad/bug-heat-wonky-recent-activity-check-688364/+merge/71756
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/bug-heat-wonky-recent-activity-check-688364 into lp:launchpad/db-devel.