launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Thanks for spotting the obvious error in my code, stub.  I feel dumb for not seeing this earlier.  I think days_since_last_update == 0 will get what I'm after, but I recall rejecting that for some inconsistency in the test results.  I'll investigate and propose again later.

As for our rational to make this a stored procedure, I think it was that it was faster to have the db execute this and I think also that we were thinking this would happen as a trigger on bug update, rather than being called from Python code. I could be recalling wrong, though. I certainly trust you and Robert about if we should move this out of stored procedure.

@lifeless
The point is to increase the heat for bugs that are currently active.  So as bugs continue to see activity, they continue to get warm, and they warm up enough to jump into the hot bugs list.  The decay in heat over time is to counteract this, so bug heat doesn't get inflated indefinitely.  This is the intent anyway, but after the review here and talking to Aaron about it today, I don't think the current implementation can succeed in that, regardless of this change or not.  I'm working through this again today and tomorrow and will propose something later, if I get something that works nicely.

As for the modeling question, we did that early on, but I didn't with these changes.  I think I'll start there again.
-- 
https://code.launchpad.net/~deryck/launchpad/bug-heat-wonky-recent-activity-check-688364/+merge/71756
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/bug-heat-wonky-recent-activity-check-688364 into lp:launchpad/db-devel.