launchpad-reviewers team mailing list archive

[Raphaël Victor Badin <raphael.badin@xxxxxxxxxxxxx>]

Raphaël Victor Badin has proposed merging lp:~rvb/launchpad/overlay-bug-827220 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #827220 in Launchpad itself: "After the comment overlay has been closed, it's not possible to click on the "Ignored" radio buttons."
  https://bugs.launchpad.net/launchpad/+bug/827220

For more details, see:
https://code.launchpad.net/~rvb/launchpad/overlay-bug-827220/+merge/71915

This branch changes the way overlay and formoverlay are hidden. Instead of using 'visibility: hidden' we now use 'display: none' because this way, the hidden overlay is not even displayed and this cannot receive events meant to be received by elements underneath it.

= Tests =

(modified)
lib/lp/app/javascript/overlay/tests/test_overlay.html

= Q/A =

On a diff page [1], change the "Ignored" status; a pop-up should appear: hit the cancel button; Changing the "Ignored" status again should make the pop-up reappear.

[1] https://dogfood.launchpad.net/ubuntu/oneiric/+localpackagediffs
-- 
https://code.launchpad.net/~rvb/launchpad/overlay-bug-827220/+merge/71915
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/overlay-bug-827220 into lp:launchpad.

=== modified file 'lib/lp/app/javascript/formoverlay/assets/formoverlay-core.css'
--- lib/lp/app/javascript/formoverlay/assets/formoverlay-core.css	2011-06-29 14:56:15 +0000
+++ lib/lp/app/javascript/formoverlay/assets/formoverlay-core.css	2011-08-17 16:02:25 +0000
@@ -1,5 +1,5 @@
 .yui3-lazr-formoverlay-hidden {
-    visibility: hidden;
+    display: none; 
 }
 
 .yui3-lazr-formoverlay-form th, .yui3-lazr-formoverlay-form td {

=== modified file 'lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html'
--- lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html	2011-07-08 06:06:15 +0000
+++ lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html	2011-08-17 16:02:25 +0000
@@ -8,6 +8,7 @@
           src="../../../../../canonical/launchpad/icing/yui/yui/yui.js">
   </script>
   <link rel="stylesheet" href="../../../../app/javascript/testing/test.css" />
+  <link rel="stylesheet" href="../assets/formoverlay-core.css" />
   <script type="text/javascript"
           src="../../../../app/javascript/testing/testrunner.js"></script>
 

=== modified file 'lib/lp/app/javascript/overlay/assets/pretty-overlay-core.css'
--- lib/lp/app/javascript/overlay/assets/pretty-overlay-core.css	2011-06-29 14:56:15 +0000
+++ lib/lp/app/javascript/overlay/assets/pretty-overlay-core.css	2011-08-17 16:02:25 +0000
@@ -39,5 +39,5 @@
 /* Hide the overlay if you use PrettyOverlay directly; if you subclass,
    you have to do this yourself with your own class yui3-yourclass-hidden. */
 .yui3-pretty-overlay-hidden {
-    visibility: hidden;
+    display: none;
 }

=== modified file 'lib/lp/app/javascript/overlay/tests/test_overlay.html'
--- lib/lp/app/javascript/overlay/tests/test_overlay.html	2011-07-08 06:21:11 +0000
+++ lib/lp/app/javascript/overlay/tests/test_overlay.html	2011-08-17 16:02:25 +0000
@@ -9,6 +9,7 @@
           src="../../../../../canonical/launchpad/icing/yui/yui/yui.js">
   </script>
   <link rel="stylesheet" href="../../../../app/javascript/testing/test.css" />
+  <link rel="stylesheet" href="../assets/pretty-overlay-core.css" />
   <script type="text/javascript"
           src="../../../../app/javascript/testing/testrunner.js"></script>
 

=== modified file 'lib/lp/app/javascript/overlay/tests/test_overlay.js'
--- lib/lp/app/javascript/overlay/tests/test_overlay.js	2011-07-08 05:12:39 +0000
+++ lib/lp/app/javascript/overlay/tests/test_overlay.js	2011-08-17 16:02:25 +0000
@@ -118,6 +118,10 @@
 
         simulate(this.overlay.get('boundingBox'), '.close .close-button', 'click');
         Assert.isFalse(this.overlay.get('visible'), "The widget wasn't hidden");
+        Assert.areEqual(
+	    'none',
+	    this.overlay.get('boundingBox').getStyle('display'),
+	    "The widget is still displayed");
     },
 
     test_click_cancel_fires_cancel_event: function() {