launchpad-reviewers team mailing list archive

[Raphaël Victor Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/launchpad/overlay-bug-827220 into lp:launchpad has been updated.

Description changed to:

This branch changes the way overlay and formoverlay are hidden. Instead of using 'visibility: hidden' we now use 'display: none' because this way, the hidden overlay is not even displayed and this cannot receive events meant to be received by elements underneath it.

== Pre-implementation notes ==
Talked about this fix with Deryck.

= Tests =
(modified)
lib/lp/app/javascript/overlay/tests/test_overlay.html

= Q/A =
On a diff page [1], change the "Ignored" status; a pop-up should appear: hit the cancel button; Changing the "Ignored" status again should make the pop-up reappear.

[1] https://dogfood.launchpad.net/ubuntu/oneiric/+localpackagediffs

For more details, see:
https://code.launchpad.net/~rvb/launchpad/overlay-bug-827220/+merge/71915
-- 
https://code.launchpad.net/~rvb/launchpad/overlay-bug-827220/+merge/71915
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/overlay-bug-827220 into lp:launchpad.