launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/post-827347 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #827347 in Launchpad itself: "Link to DSD pages even if none require attention"
  https://bugs.launchpad.net/launchpad/+bug/827347

For more details, see:
https://code.launchpad.net/~jtv/launchpad/post-827347/+merge/72376

= Summary =

Fix up a bit I missed in a previous UI change.


== Proposed fix ==

On the DistroSeries page for a derived series, the links to differences from parent series were linked as "ⓘ <1234 packages only in a parent>" but to accommodate changes to the text, we changed this to "ⓘ 1234 packages <only in a parent>".

I missed a spot though: the link for packages only in the derived series itself is still in the old format.  "ⓘ <2345 packages only in Oneiric>".  This branch makes that conform to the other links.


== Pre-implementation notes ==

As discussed intensively with Julian and Raphaël, complete with mockups.  It's just my implementation that was lacking.


== Implementation details ==

There is no ⓘ.  In the real UI that's just a sprite.


== Tests ==

{{{
./bin/test -vvc lp.registry.browser.tests -t series -t deriv
}}}


== Demo and Q/A ==

Have a look at https://dogfood.launchpad.net/ubuntu/oneiric/ and you should see three more or less consistent lines of references to package differences.  (Well, the first line is different but that's deliberate).


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/distroseries-portlet-derivation.pt
-- 
https://code.launchpad.net/~jtv/launchpad/post-827347/+merge/72376
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/post-827347 into lp:launchpad.

=== modified file 'lib/lp/registry/templates/distroseries-portlet-derivation.pt'
--- lib/lp/registry/templates/distroseries-portlet-derivation.pt	2011-08-18 11:55:52 +0000
+++ lib/lp/registry/templates/distroseries-portlet-derivation.pt	2011-08-22 03:50:18 +0000
@@ -45,10 +45,10 @@
             </a>
           </li>
           <li class="sprite info" tal:condition="nb_diffs_in_child">
+            <tal:differences_count replace="view/wordDifferencesInChild">
+              345 packages
+            </tal:differences_count>
             <a tal:attributes="href view/link_to_differences_in_child">
-              <tal:differences_count replace="view/wordDifferencesInChild">
-                345 packages
-              </tal:differences_count>
               only in
               <tal:child replace="context/displayname">
                 Natty