launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

> On 23/08/11 14:11, William Grant wrote:
> > You should add pillar_category to IPillar, rather than having a separate
> security declaration for it.
> >
> 
> Thought about that but then I'd have to add pillar_category to
> everything that implements IPillar. Is that what we really want to do?
> We are just trying to correct the nomenclature for a couple of misnamed
> pillar types, hened the localised implementation. I was trying to avoid
> polluting too much of the code base ie keep the footprint of the change
> as small as possible.

The pillars are IProduct, IProjectGroup and IDistribution. All of which seem to already have it :)
-- 
https://code.launchpad.net/~wallyworld/launchpad/incorrect-picker-label-830935/+merge/72513
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/incorrect-picker-label-830935 into lp:launchpad.