launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

On 23/08/11 14:11, William Grant wrote:
> You should add pillar_category to IPillar, rather than having a separate security declaration for it.
> 

Thought about that but then I'd have to add pillar_category to
everything that implements IPillar. Is that what we really want to do?
We are just trying to correct the nomenclature for a couple of misnamed
pillar types, hened the localised implementation. I was trying to avoid
polluting too much of the code base ie keep the footprint of the change
as small as possible.

> Also, I'm not sure about the way the categories are displayed. Should they be there at all? If they should be there (which I really doubt), they should probably be somehow separated from the pillar name (different colour?) and be lowercase.

I don't really want to change what's been done previously wrt
presentation etc - that's better done in a separate branch. I personally
like having that info there because it gives context to the picker entry.

-- 
https://code.launchpad.net/~wallyworld/launchpad/incorrect-picker-label-830935/+merge/72513
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/incorrect-picker-label-830935 into lp:launchpad.